Add Unispeech & Unispeech-SAT#13963
Merged
patrickvonplaten merged 30 commits intohuggingface:masterfrom Oct 26, 2021
Merged
Conversation
Contributor
Author
|
Wait until #13877 is merged |
src/transformers/models/unispeech_sat/modeling_unispeech_sat.py
Outdated
Show resolved
Hide resolved
src/transformers/models/unispeech_sat/modeling_unispeech_sat.py
Outdated
Show resolved
Hide resolved
src/transformers/models/unispeech_sat/modeling_unispeech_sat.py
Outdated
Show resolved
Hide resolved
src/transformers/models/unispeech_sat/modeling_unispeech_sat.py
Outdated
Show resolved
Hide resolved
src/transformers/models/unispeech_sat/modeling_unispeech_sat.py
Outdated
Show resolved
Hide resolved
src/transformers/models/unispeech_sat/modeling_unispeech_sat.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
PR is good for review IMO:
|
Contributor
Author
|
I think we can merge the pretrained models now. To make them "promotable" we should still do 2 things:
|
sgugger
approved these changes
Oct 21, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for adding those two models!
anton-l
approved these changes
Oct 25, 2021
Member
anton-l
left a comment
anton-l
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot for debugging the original models!
|
|
||
| # quantize all (unmasked) extracted features and project to final vq dim | ||
| extract_features = self.dropout_features(outputs[1]) | ||
| quantized_features, codevector_perplexity = self.quantizer(extract_features) |
Member
There was a problem hiding this comment.
Doesn't UniSpeech use the same masking strategy for quantization as Wav2Vec? Or did you remove masking just for debugging purposes?
Contributor
Author
There was a problem hiding this comment.
pretraining is quite different and not implemented yet really - this code should not be used yet
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds UniSpeech from Microsoft: https://github.com/microsoft/UniSpeech
TODOS:
Run UniSpeech models and verify that HF forward pass yields same output
Add UniSpeech checkpoints: https://huggingface.co/microsoft/unispeech-large-1500h-cv
Run UniSpeech-SAT and verify that HF forward pass yields same output (blocked by: Access Required for UniSpeech-SAT models microsoft/UniSpeech#4)
Add UniSpeech-SAT checkpoints
Add UniSpeech vocab and preprocessing (verify with Microsoft)
Add UniSpeech vocab and preprocessing (verify wiht Microsoft)
Verify naming with Microsoft & make README.md's pretty
Clean PR and add tests
Verify fine-tuning works
Future PR: